primitive golang evaluator for k8s/kind-node-image version alignment check #2048
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
- Coverage 73.82% 73.02% -0.80%
==========================================
Files 81 82 +1
Lines 7365 7444 +79
==========================================
- Hits 5437 5436 -1
- Misses 1588 1668 +80
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Description
From current K8S_VERSION calculation in Makefile, this tool will receive the version and the location of the modfile for kind, retrieve the image.go file from the floating tag's release of the image.go module which contains the floating k8s version tag used for the node image, compare that floating tag to ensure that the default kind-node-image tag is greater or equal to the currently selected k8s version.
Tested to verify this exits status 1 before the kind version bump to v0.29.0 (included here just because it will permafail without it in current conditions.
Reviewer Checklist